Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

wiki walky feature doesn't prompt user for camera permission #36

Closed
SiamakSamie opened this issue Feb 11, 2019 · 0 comments
Closed

wiki walky feature doesn't prompt user for camera permission #36

SiamakSamie opened this issue Feb 11, 2019 · 0 comments
Assignees
@SiamakSamie
Labels
bug Something isn't working
Milestone
Sprint 3 (Release 2)

Comments

@SiamakSamie
Copy link
Collaborator

Description: Unless the user manually goes into their phone setting and enables camera permission, the app will crash when using wiki walky

To Reproduce:

Steps to reproduce the behavior:

  1. fresh download app
  2. enable wiki walky in settings
  3. go to an article
  4. app will crash

Expected behavior:
The app should prompt user to enable the camera hardware

Environment:
Reproduceable on all android devices on all recent versions of android
@SiamakSamie SiamakSamie added the bug Something isn't working label Feb 11, 2019
@SiamakSamie SiamakSamie self-assigned this Feb 15, 2019
@SiamakSamie SiamakSamie added this to the Sprint 3 (Release 2) milestone Feb 15, 2019
@SiamakSamie SiamakSamie added Epic and removed Epic labels Feb 15, 2019
SiamakSamie added a commit that referenced this issue Feb 15, 2019
@SiamakSamie
[#36] Created listener for wikiWalkey switch to trigger the "camera p…
76e99a8 
…ermission" prompt. Handling edge cases. Created unit tests
@SiamakSamie SiamakSamie mentioned this issue Feb 15, 2019
Merged
5 tasks
SiamakSamie added a commit that referenced this issue Feb 15, 2019
@SiamakSamie
[#36] put the wrong prefs, changes it to the appropriate one
25448b3
SiamakSamie added a commit that referenced this issue Feb 21, 2019
@SiamakSamie
[#36] stylefix
da675da
SiamakSamie added a commit that referenced this issue Feb 21, 2019
@SiamakSamie
[#36] stylefix 2
71ab26c
philippelorange added a commit that referenced this issue Mar 5, 2019
@philippelorange
Merge pull request #53 from alexstojda/camera-bug-fix
4fae780 
[#36] enabled "camera permission" prompt and handling edge cases
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SiamakSamie SiamakSamie

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 3 (Release 2)
Development

No branches or pull requests
2 participants
@SiamakSamie @philippelorange