Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Static analysis #141

Merged
merged 52 commits into from
Aug 10, 2017
Merged

Static analysis #141

merged 52 commits into from
Aug 10, 2017

Commits on Aug 8, 2017

  1. Introduce static analysis via novoda static analysis plugin + Detekt

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    23d1545 View commit details
    Browse the repository at this point in the history

  2. Make class final and break long line

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    7112e46 View commit details
    Browse the repository at this point in the history

  3. Shorten loooong lines

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    b4c8b70 View commit details
    Browse the repository at this point in the history

  4. Make package class final

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    ae0854d View commit details
    Browse the repository at this point in the history

  5. Remove magic numbers and disable magic voodo inspection

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    c1a2ebe View commit details
    Browse the repository at this point in the history

  6. Fix field name

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    ed7528b View commit details
    Browse the repository at this point in the history

  7. Extracted magic numbers

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    9bf4c2d View commit details
    Browse the repository at this point in the history

  8. Break looong line

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    2048376 View commit details
    Browse the repository at this point in the history

  9. Checkstyle checks

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    79b4c45 View commit details
    Browse the repository at this point in the history

  10. Hide constructors of contract classes

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    08c9f8e View commit details
    Browse the repository at this point in the history

  11. Checkstyling

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    8c4e55b View commit details
    Browse the repository at this point in the history

  12. Remove unused layout

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    61625d1 View commit details
    Browse the repository at this point in the history

  13. Checkstyling

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    b165c1f View commit details
    Browse the repository at this point in the history

  14. Ingore Visibility modifiers for fields with @iNJECTiON annotation

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    de64fc9 View commit details
    Browse the repository at this point in the history

  15. Excluse IAB and preference fragment

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    80ab9a3 View commit details
    Browse the repository at this point in the history

  16. Checkstyle checks

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    efe14be View commit details
    Browse the repository at this point in the history

  17. Remove 'check'

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    3cc5aed View commit details
    Browse the repository at this point in the history

  18. Check styling

    @alexstyl
    alexstyl committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    1d3ec7d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2017

  1. Get rid of all warnings

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    df2c1bf View commit details
    Browse the repository at this point in the history

  2. Even more checkstyles

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    02b7dc5 View commit details
    Browse the repository at this point in the history

  3. Checkstyling yo

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    b210505 View commit details
    Browse the repository at this point in the history

  4. Even moar checkstyle checking

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    04774ce View commit details
    Browse the repository at this point in the history

  5. Remove final of some classes so that they can be mocked

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    8207ecf View commit details
    Browse the repository at this point in the history

  6. Checking

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    258c933 View commit details
    Browse the repository at this point in the history

  7. Refactor fb credentials

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    2fd9291 View commit details
    Browse the repository at this point in the history

  8. Supress final check

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    aaf649f View commit details
    Browse the repository at this point in the history

  9. Add explanation for supresswarning

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    881ac50 View commit details
    Browse the repository at this point in the history

  10. Use NamedayUserSetttings in tests

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    7c73da5 View commit details
    Browse the repository at this point in the history

  11. Inject into NamedayListPreference

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    b3e0977 View commit details
    Browse the repository at this point in the history

  12. Rename RingtonePreference to ClickableRingtonePreference

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    2ca8ad3 View commit details
    Browse the repository at this point in the history

  13. Supress warnngs for SoundNode

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    66f5ef5 View commit details
    Browse the repository at this point in the history

  14. Remove serialisable interface from SoundNode (as no one was using it)

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    33c84d5 View commit details
    Browse the repository at this point in the history

  15. Make comparators also Serializable 

    This is due to the findbugs warning: This class implements the Comparator interface. You should consider whether or not it should also implement the Serializable interface. If a comparator is used to construct an ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator is also serializable. As most comparators have little or no state, making them serializable is generally easy and good defensive programming.
    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    63b706c View commit details
    Browse the repository at this point in the history

  16. Remove unused field

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    f180485 View commit details
    Browse the repository at this point in the history

  17. Specify UTF-8 encoding when loading JSON

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    f16e5cf View commit details
    Browse the repository at this point in the history

  18. Return copy of array on the getter

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    1b9bd65 View commit details
    Browse the repository at this point in the history

  19. Call parseInt instead of valueOf in order to extract ints

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    8eb88f3 View commit details
    Browse the repository at this point in the history

  20. Extract UserOptions into its own class

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    69b053d View commit details
    Browse the repository at this point in the history

  21. Remove obsolete casting

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    f2ff3dd View commit details
    Browse the repository at this point in the history

  22. Supress all warnings of PreferenceFragment

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    6a1fc92 View commit details
    Browse the repository at this point in the history

  23. Cast before divizion

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    44464c7 View commit details
    Browse the repository at this point in the history

  24. Divide by float

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    9655ebb View commit details
    Browse the repository at this point in the history

  25. Casting

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    7e21c8c View commit details
    Browse the repository at this point in the history

  26. @SuppressWarnings("all") for Security

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    635c11f View commit details
    Browse the repository at this point in the history

  27. Long.parse instead of valuePf

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    b89d677 View commit details
    Browse the repository at this point in the history

  28. Private static class

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    6dc9c36 View commit details
    Browse the repository at this point in the history

  29. Use parseInt instead of valueOf

    @alexstyl
    alexstyl committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    0f278f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2017

  1. Remove PlayGroundActivity

    @alexstyl
    alexstyl committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f8e771e View commit details
    Browse the repository at this point in the history

  2. Increase the threshold of analysis errors and warnings 

    Novoda Static Analysis: Errors 209, warnings 7
Detekt: warning 24, fail 24
    @alexstyl
    alexstyl committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    e3406fa View commit details
    Browse the repository at this point in the history

  3. Set detekt fail limits to 26

    @alexstyl
    alexstyl committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    45f88eb View commit details
    Browse the repository at this point in the history

  4. Move DebugFragment injection to the DebugAppComponent

    @alexstyl
    alexstyl committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    0b070ee View commit details
    Browse the repository at this point in the history

  5. Change Errors to 54 and warnings to 196

    @alexstyl
    alexstyl committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7c145d7 View commit details
    Browse the repository at this point in the history