Multi platform build #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexta69
reviewed
Jan 24, 2021
|
|
||
| FROM python:3.8-alpine | ||
| ARG ARCH | ||
| COPY qemu-${ARCH}-static* /usr/bin |
There was a problem hiding this comment.
This will break the simple use case of checking out the code and running "docker build", for local development. I wonder if there's any solution possible to still support this use case.
| rm -rf $tempdir/* | ||
| done | ||
|
|
||
| trap "exit 1" HUP INT PIPE QUIT TERM |
There was a problem hiding this comment.
Don't the trap commands need to be at the top of the file, to be executed first? If you're already at the end of the execution, it seems that the traps are no longer relevant anymore, no?
|
Done using GitHub actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a script for building multi-platform images.
This could also be embedded in a CI platform.
It would be cool if you could run the build with "-p true" so I don't have to upload the image to Docker Hub myself ...
If you want, I'd be happy to help you create a CI pipeline for this project. Just get in touch with me.
Many greetings
Florian
Fixes #12