Multiarch Docker build via GitHub Actions #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexta69
requested changes
Mar 10, 2021
| uses: docker://lsiodev/readme-sync:latest | ||
| env: | ||
| DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }} |
There was a problem hiding this comment.
I suppose this can also use the token, and the password isn't really needed, right? let's try changing it to TOKEN (I can't edit your PR, only propose changes..)
There was a problem hiding this comment.
That was my first instinct, but it didn't work for me. I guess I might have just made a typo somewhere...
| context: . | ||
| platforms: linux/amd64,linux/arm64,linux/arm/v7 | ||
| push: true | ||
| tags: ${{ secrets.DOCKERHUB_REPOSITORY }}:latest |
There was a problem hiding this comment.
let's change the label to "github" for now, so we can test it out
|
@xescure I actually just copied the file and pushed it myself, so you don't need to bother making the changes I requested in the comments, we can just close the PR once everything works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos before application:
alexta69/metube):latest