Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Lang Front-End selection popup not working on mobile. #550

Closed
xcsn2005 opened this issue Oct 6, 2018 · 2 comments
Closed

Multi-Lang Front-End selection popup not working on mobile. #550

xcsn2005 opened this issue Oct 6, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@xcsn2005
Copy link

xcsn2005 commented Oct 6, 2018

Version 3.3.5 of Bootstrap doesn't recognize touch events on modern displays for popups it creates. Thus, you cannot change language on mobile.

Also, Bootstrap >3.3.5 up to 4.0 has XSS security vulnerabilities due to use of "data-target" attribute in HTML code, see here : SNYK Report

I tried upgrading to latest Bootstrap 4.1.3 (which requires Popper.js), but it doesn't fit with Bootswatch Paper theme for Bootstrap 3.3.5 anymore, as the "Paper" theme has been deprecated in latest versions.

What to do?

@alextselegidis alextselegidis self-assigned this Oct 10, 2018
@alextselegidis
Copy link
Owner

Hi @xcsn2010, I was planning to upgrade Bootstrap soon, as the new version works nicely. I'll mark this as a feature of 1.4.0 and try to integrate asap.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!

@alextselegidis alextselegidis added the enhancement New feature or request label Oct 10, 2018
@alextselegidis alextselegidis added this to the v1.4.0 milestone Oct 10, 2018
@yrammos
Copy link
Contributor

yrammos commented Apr 1, 2020

@xcsn2005 if I understand correctly, a fix for this is included in my fork, TekhneeAppointments, where, additionally, the language selector is itself multilingual (displaying each option in the respective language) and supports ISO language variants (e.g. British English). I haven't submitted a PR because the changes are invasive and, frankly, not as tidy as I'd like. But the particular issue you're describing might potentially be addressed by changing:

li.language:hover {
    cursor: pointer;
    color: #005580;
}

to

li.language {
    cursor: pointer;
}

li.language:hover {
    color: #005580;
}

in /src/assets/css/general.css.

@alextselegidis alextselegidis changed the title Multi-Lang Front-End selection popup not working on Mobile Multi-Lang Front-End selection popup not working on mobile. Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants