Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument for assertScreenMatchesImageNamed to set diff threshold. #57

Merged
merged 2 commits into from Sep 10, 2013
Merged

Add argument for assertScreenMatchesImageNamed to set diff threshold. #57

merged 2 commits into from Sep 10, 2013

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Sep 4, 2013

Usage:

assertScreenMatchesImageNamed("imagename", "message", 2.0) // max allowed diff will be 2.0
assertScreenMatchesImageNamed("imagename", "message") // when you not pass any value, threshold will be MAX_ALLOWED_DIFF_VALUE(1.0)

@alexvollmer
Copy link
Collaborator

This looks good. I had a couple of small comments on the patch. If you can address those I'll happily add this.

Thanks for the contribution!

@giginet
Copy link
Contributor Author

giginet commented Sep 7, 2013

Thank you for your code reviewing.
I fixed some issues by your advice.

Please check it out again.

alexvollmer added a commit that referenced this pull request Sep 10, 2013
@alexvollmer
Merge pull request #57 from giginet/image_assertion_threshold
e811379 
Add argument for assertScreenMatchesImageNamed to set diff threshold.
@alexvollmer alexvollmer merged commit e811379 into vkolgi:master Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giginet @alexvollmer