Fix URL display style

[marcosnils]

• Removes unnecessary function
• Fixes File url not showing up #13

[alexweininger]

@marcosnils
Thanks for the pr!

Can you provide a screenshot of the popup using your code?

One of the reasons I had

file.filename.substring(0, file.filename.lastIndexOf('\\') + 1)

instead of

linkUrl.innerHTML = file.filename;

was to make sure the displayed url was not too long and messy. I wanted to do this because 1. I want it to fit on one line, and 2. I want it to be easy to read.

I am worried that using the full file path won't meet these. I know I should have put this in the original issue, sorry.

Do you have any ideas of how to solve this problem?

-alex

[marcosnils]

This is how it looks in my machine. The problem was that several filenames didn't have the \\ at all in the path so that line was causing the url not to render at all.

What you can do if you don't want the path to mess with the length is truncate the url with ellipsis using css (https://css-tricks.com/snippets/css/truncate-string-with-ellipsis/)

[alexweininger]

I like the ellipsis idea however I think the most useful information in the filepath is at the end. I would like something like a reverse ellipse, so that we always see the end of the path and the front gets cut off if the path is too long.

Also - all the file paths begin with "file://" if I can recall correctly. So the issue is something else. See the updates issue #13.

[marcosnils]

Also - all the file paths begin with "file://" if I can recall correctly. So the issue is something else. See the updates issue #13.

That wasn't my case. The issue about url's not appearing was because a styling issue that I also fixed in the PR. The URL's are there, it's just that the CSS styles were causing the file name to overlap them. You can try merging this PR locally in your machine and check out how it works.

[alexweininger]

You can try merging this PR locally in your machine and check out how it works.

Will do👍

[alexweininger]

@marcosnils just checked it out, looks great! Sorry for my pestering.

I will note that there are further improvements from this that need to be made. I will link the issues here later.

[alexweininger]

Looks good!

[marcosnils]

@marcosnils just checked it out, looks great! Sorry for my pestering.

No worries, glad to help! :)