Added "No PDFs found" #31
Conversation
Added a message that will be displayed if no PDF's were found. The message is a simple default li tag containing a div that will be removed if the count is greater than 0. I think a search field will be a nice feature at some point. If it's added, it may be better to make the visibility hidden rather tan remove. That way, it can be made visible if the search yields no results.
|
I was thinking about this the other day! 👍👍 Looks perfect. A search function and sorting are on my radar for the future. |
|
Make sure you're on the most recent version of master |
|
Sweet! - Yea, it should be. I'm not seeing any conflicts.. |
|
Hey @bradleyasu I'm sorry, but I've been having some weird glitches on your version. I'm not saying this was caused by you at all, but to make sure I am not going to merge it just yet. I want some others to test out your version to confirm that it is good to go.Here are the glitches, they might just be Chrome glitches. (sorry for my terrible circling)
|
alexweininger
added
bug
|
@bradleyasu and @alexweininger Checked out this PR. I did not see the same UI issues, but I did notice a large gap below the footer. Anyone else seeing that? Here are some screenshots of how the extension renders in my browser:
|
|
I am having the same issue @hwinn4. I'll have more time later this week to check it out, or @bradleyasu might fix it before I get to :) |
|
Hey guys, sorry for being MIA on this lately - I apologize for the confusion and odd behavior, I haven't really experienced it, but will try to check it out this week as well. |
|
@bradleyasu no problem at all! There's no rush. |
Added a message that will be displayed if no PDF's were found. The message is a simple default li tag containing a div that will be removed if the count is greater than 0.
I think a search field will be a nice feature at some point. If it's added, it may be better to make the visibility hidden rather tan remove. That way, it can be made visible if the search yields no results.
Fixes issue
There is no issue for this - I was just kind of playing around with this. If you don't like the changes, please throw them out. I will make comments in the future about things and if you like the idea and there is a general issue open, I will commit to that.
Screenshots
before PR
after PR
Proposed Changes
If your current branch is
master, you should choose to create a new branch for your commit and then create a pull request.