Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dist by default #16

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Ignore dist by default #16

merged 2 commits into from
Mar 7, 2021

Conversation

alexwilson
Copy link
Owner

@alexwilson alexwilson commented Mar 6, 2021

Why?

Following #14, this is a fairly simple & reliable way of preventing accidental commits to dist/*, while preserving previous auto-rebuild behaviour.

What?

  • .gitignore dist/* by default (thanks for this @bdo!)
  • instruct stefanzweifel/git-auto-commit-action to force add dist/* which supersedes the gitignore rule.

Anything else?

This fixes #13 & closes #14.

@alexwilson
Copy link
Owner Author

I tested this out before creating this branch & PR: https://github.com/alexwilson/enable-github-automerge-action/actions/runs/627869758

Copy link
Collaborator

@JakeChampion JakeChampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@alexwilson alexwilson merged commit 00f25b4 into main Mar 7, 2021
@alexwilson alexwilson deleted the ignore-dist-by-default branch March 7, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devs need to be careful not to commit the dist directory
3 participants