feat: New success message, and attempt to check if a PR has been actually enbaled #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilson
added
bug
JakeChampion
reviewed
Mar 7, 2021
| core_1.debug(`Enabling auto-merge for pull-request #${pullRequest.number}`); | ||
| yield this.enableAutoMerge(pullRequestId, mergeMethod); | ||
| core_1.debug(`Successfully enabled auto-merge for pull-request #${pullRequest.number}`); | ||
| core_1.debug(`Enabling auto-merge for pull-request #${pullRequest.number}...`); |
There was a problem hiding this comment.
Should this file have been commited?
There was a problem hiding this comment.
Yep, this is re-generated automatically on each push. Maybe a tad unintuitive... 😓
|
Thanks for taking a look @JakeChampion - I'll revert this if it causes any unexpected behaviour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Towards #18, this is an attempt to log more of what goes on when an AutoMerge request is sent.
What?
Attempt to log the
enabledAt&enabledByfields, and when they remain empty after a synchronous mutation, throw an error.I'm not happy with this approach - ideally we'd be checking the actual status of a response. Unfortunately as the mutation doesn't include a status field.
So instead we check the AutoMergeRequest field in the PullRequest, and attempt to check if it has both
enabledAt&enabledByproperties - and that they're valid.