Skip to content

setted latest version of browser by default #76

Merged
merged 3 commits into from
Jul 2, 2018

Conversation

iFreezy
Copy link
Contributor

@iFreezy iFreezy commented Jun 5, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jun 5, 2018

Coverage Status

Coverage decreased (-1.3%) to 80.04% when pulling 5055428 on iFreezy:browser_ver into 75fb332 on alfa-laboratory:master.

capabilities.setVersion(loadSystemPropertyOrDefault(BROWSER_VERSION, "60.0"));
capabilities.setVersion(loadSystemPropertyOrDefault(BROWSER_VERSION, "latest"));
capabilities.setCapability(RESOLUTION, String.format("[%s]x[%s]",
loadSystemPropertyOrDefault(WINDOW_WIDTH,1920), loadSystemPropertyOrDefault(WINDOW_HEIGHT,1080)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1920 и 1080 - дефолтные и много где повторяются, вынеси в поля

@GannaChernyshova GannaChernyshova merged commit 166afe9 into alfa-laboratory:master Jul 2, 2018
snfrolov added a commit to snfrolov/akita that referenced this pull request Jul 2, 2018
setted latest version of browser by default (alfa-laboratory#76)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants