fix(textarea): fixed height label overlapping on view=filled #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reme3d2y
changed the title
SiebenSieben
approved these changes
Apr 17, 2020
delete-merged-branch
bot
deleted the
fix/textarea-view-filled-label-overlapping
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Мотивация и контекст
#1118
Данная проблема возникает при сочетании
view="filled"иmaxRows.Из-за особенностей вертки - контент во время скрола наезжает на лейбл.
Решение
Перенес заливку из
textarea.textarea__controlв родительский контейнер.textarea__innerи добавил дополнительный паддинг сверху при фокусе или если есть введенное значение.Было
Стало