propTypes: added value, onChange #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to correct usage of this control in typescript projects
GREENpoint
reviewed
May 24, 2017
| fractionLength: Type.number | ||
| fractionLength: Type.number, | ||
| /** Содержимое поля ввода, указанное по умолчанию */ | ||
| value: Type.string, |
There was a problem hiding this comment.
Кажется, более правильно это решать на уровне library-utils. @Heymdall что думаешь?
There was a problem hiding this comment.
Да, конечно это там надо править. Но я не уверен когда на это будет время, я когда то пробовал это сделать, из коробки просто завести наследование пропсов не получилось. Мне кажется как временный фикс - можно либо на уровне проекта подсовывать другие тайпинги, либо тут добавить их временно. Когда сделаем полноценную генерацию - можно будет грохнуть
There was a problem hiding this comment.
Ставьте эту задачу на меня
Merged
|
Пока деклайню: подключайте изменные *.d.ts через webpack. @stepancar берет таску на доделать генерацию. |
|
@Like2Read залей последний фижер. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to correct usage of this control in typescript projects
Добавил описание поля value и событие onChange в propTypes
Мотивация и контекст
Без этого изменения эти поля не доступны в typescript
money-input.d.ts.txt