Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose all box types #61

Merged
merged 1 commit into from
Mar 26, 2022
Merged

expose all box types #61

merged 1 commit into from
Mar 26, 2022

Conversation

cTopher
Copy link
Contributor

@cTopher cTopher commented Sep 29, 2021

Instead of only exposing Mp4Box type, expose all box types to consumers.

@alfg
Copy link
Owner

alfg commented Dec 21, 2021

Hey @cTopher, sorry for the late response and thanks for the PR. Any context behind exposing all the box types?

@Serial-ATA
Copy link
Contributor

@alfg The box types are exposed in public fields of the exported types. Mp4Track for example has 2/3 of its fields with private box types, so you can't see their structure in the docs.

pub struct Mp4Track {
    pub trak: TrakBox, // private
    pub trafs: Vec<TrafBox>, // private
    pub default_sample_duration: u32,
}

@alfg alfg merged commit b48066f into alfg:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants