Mp4Writer should use co64 by default, then convert to stco is possible for compatibility #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for compatibility
|
Thanks for this! Sorry for the late response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Mp4Writer to support writing mp4 files that are larger than 4GB. Previously the Chunk Offset Atom was used exclusively, so if you built an MP4 file that was larger than 4GB, the Chunk Offset Atom was silently corrupted. This change uses the co64 atom by default, and then checks for stco compatibility at the end of the track write. If all the offsets are under the 2^32 limit, then a stco atom is written, otherwise a co60 atom is written.