Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding search function #199

Merged
merged 3 commits into from
Oct 5, 2019
Merged

adding search function #199

merged 3 commits into from
Oct 5, 2019

Conversation

Chrispy404
Copy link
Contributor

@Chrispy404 Chrispy404 commented Oct 5, 2019

This request allows users to search for drinks via keyword, solving feature request #191.

Known bug:
Pressing space bar consistently returns the same cocktails. These can be seen here. I'm not sure why this is caused. none of those drinks have empty keywords attached to them.

Copy link
Owner

@alfg alfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chrispy404! It looks good. One minor fix before I can merge.

>Ingredients</b-form-checkbox>
<b-form-checkbox
v-b-tooltip.hover
title="You can search for multiple ketwords by seperating them with a space"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here on keywords.

@Chrispy404
Copy link
Contributor Author

Fixed that up. Should be all good to merge now.

@alfg alfg merged commit cd12086 into alfg:master Oct 5, 2019
@alfg
Copy link
Owner

alfg commented Oct 5, 2019

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants