#504 mailgun mailer: close response using try with resource

alfio-event · Sep 13, 2018 · 108f448 · 108f448
1 parent 94919e0
commit 108f448
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/main/java/alfio/manager/system/MailgunMailer.java b/src/main/java/alfio/manager/system/MailgunMailer.java
@@ -105,12 +105,10 @@ public void send(Event event, String to, List<String> cc, String subject, String
                     .header("Authorization", Credentials.basic("api", apiKey))
                     .post(formBody).build();
 
-            Response resp = client.newCall(request).execute();
-            if (!resp.isSuccessful()) {
-                log.warn("sending email was not successful:" + resp);
-            } else {
-                //close response body, in order to prevent leaks
-                resp.body().close();
+            try(Response resp = client.newCall(request).execute()) {
+                if (!resp.isSuccessful()) {
+                    log.warn("sending email was not successful:" + resp);
+                }
             }
         } catch (IOException e) {
             log.warn("error while sending email", e);