Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc optimizations #325

Closed
6 tasks done
syjer opened this issue Aug 9, 2017 · 1 comment
Closed
6 tasks done

misc optimizations #325

syjer opened this issue Aug 9, 2017 · 1 comment
Assignees
@syjer
Labels
enhancement
Projects
1.12
Milestone
1.12

Comments

@syjer
Copy link
Member

syjer commented Aug 9, 2017 •
edited

This is a task containing optimizations tasks:

  • EventApiController.getCategoriesWithTickets -> n+1 when fetching the description
  • try to replace TicketCategoryWithStatistic -> removed
  • EventApiController.getCategoriesWithTickets code path can be optimized as we can know on the db side if a category has tickets inside it -> removed
  • EventStatisticsManager.getAllEvents -> n+1->change eventRepository.findByOrganizationId in findByOrganizationIds
  • UserManager.findUserOrganizations can be done in single query on the db
  • EventStatisticsManager.loadModifiedTickets -> n+1 -> should join ticketRepository + ticketReservationRepository + transactionRepository
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318, #325 misc optimizations
14b3857
@syjer syjer self-assigned this Aug 13, 2017
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 remove getCategoriesContainingTickets call, remove ticketcategor…
75b769b 
…ywithstatistic
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 convert eventRepository.findByOrganizationId in eventRepository.…
ceb4e5a 
…findByOrganizationIds -> remove n+1 call
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 fix typo
f2b0d06
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 initial effort to get all orgs in a single query
e063d46
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 fix ambigous column name
f2ce751
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 switch UserManager.findUserOrganizations to the optimized call
fca2d8d
@syjer syjer added this to the 1.12 milestone Aug 14, 2017
@syjer syjer added this to In progress in 1.12 Aug 14, 2017
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#325 fix EventStatisticsManager.loadModifiedTickets: fetch data throu…
bc33147 
…gh a view
@syjer
Copy link
Member Author

syjer commented Aug 14, 2017

this first set is done :)

@syjer syjer closed this as completed Aug 14, 2017
@syjer syjer moved this from In progress to Ready for testing in 1.12 Aug 14, 2017
@cbellone cbellone moved this from Ready for testing to Done in 1.12 Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
No open projects
1.12
Done
Milestone
1.12
Development

No branches or pull requests
1 participant
@syjer