Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reservations should not be deleted automatically when expired #447

Closed
stephanj opened this issue May 21, 2018 · 4 comments
Closed

Reservations should not be deleted automatically when expired #447

stephanj opened this issue May 21, 2018 · 4 comments
Assignees
@syjer

Comments

@stephanj
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Reservations should not get deleted automatically when expired.
This should be a manual task.
@syjer
Copy link
Member

syjer commented May 24, 2018

note: the manual deletion must be applied only for the reservation in the state: payment_pending.

@syjer
Copy link
Member

syjer commented May 24, 2018

method that need some modifications:

  • TicketReservationManager.cleanupExpiredOfflineReservations

syjer added a commit that referenced this issue May 24, 2018
@syjer
implement: #447, add the possibility to configure the auto-removal of…
1ae56d9 
… expired offline-payment
@syjer
Copy link
Member

syjer commented May 24, 2018

should be implemented, will do a PR

syjer added a commit that referenced this issue May 25, 2018
@syjer
update #447 -> change key name
73e5295
syjer added a commit that referenced this issue May 25, 2018
@syjer
update #447 -> fix condition
a29205f
cbellone pushed a commit that referenced this issue May 25, 2018
@syjer @cbellone
implement: #447, add the possibility to configure the auto-removal of…
a08598f 
… expired offline-payment (#452)

* implement: #447, add the possibility to configure the auto-removal of expired offline-payment

* update #447 -> change key name

* update #447 -> fix condition
cbellone pushed a commit that referenced this issue May 25, 2018
@syjer @cbellone
implement: #447, add the possibility to configure the auto-removal of…
0470777 
… expired offline-payment (#452)

* implement: #447, add the possibility to configure the auto-removal of expired offline-payment

* update #447 -> change key name

* update #447 -> fix condition

(cherry picked from commit a08598f)
@syjer
Copy link
Member

syjer commented May 25, 2018

done.

@syjer syjer closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephanj @syjer