Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import new reservation flow #464

Closed
syjer opened this issue Jun 7, 2018 · 8 comments
Closed

import new reservation flow #464

syjer opened this issue Jun 7, 2018 · 8 comments
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M0

Comments

@syjer
Copy link
Member

syjer commented Jun 7, 2018

Work done in the fork:

I'm not able to merge it cleanly so it will imported piece by piece in a new branch and then merged in the master.
@syjer syjer self-assigned this Jun 7, 2018
@syjer syjer added this to the 2.0-M0 milestone Jun 11, 2018
@syjer
Copy link
Member Author

syjer commented Jun 22, 2018

note: there are some UI issue with the mobile version

@syjer
Copy link
Member Author

syjer commented Jun 22, 2018

-> rough list of changes:

syjer added a commit that referenced this issue Jun 24, 2018
@syjer
#464 import initial model changes
618d832
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import initial model changes
73c8438
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import stubs for new flow
8cbea16
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import initial model changes
db224c6
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import stubs for new flow
eaf0e0f
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 make the free flow work: still WIP
2743d91
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 add text/breadcrumb
47bc408
@syjer
Copy link
Member Author

syjer commented Jun 26, 2018 •
edited

Make the reservation flow work for:

  • free
  • offline payment
  • stripe
  • paypal
  • on site

Notes: on site payment should not have a receipt generated/invoice generated(?)

syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 handle back, fix test
dda5ca6
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 remove payment form from the reservation-page.ms
9ab83b0
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import initial model changes
a4618d9
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import stubs for new flow
6afb949
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 make the free flow work: still WIP
45e2bb2
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 add text/breadcrumb
c6ee21d
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 handle back, fix test
c922c5a
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 remove payment form from the reservation-page.ms
5607276
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 enable stripe, refactor
c6d52b4
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 re-enable paypal
46775ca
@syjer
Copy link
Member Author

syjer commented Jun 26, 2018 •
edited

TODO:

  • import the ui/ux from the devoxx/alf.io version
  • remove the Term and Condition checkbox in the step2
  • remove the Term and Condition checkbox in payment page after paypal redirect
  • re-enable the validations (!)
  • display error message for additional info
  • rename PaymentForm
  • add a new Form class for the payment/confirmation step
  • enable validation for payment step: move code
  • redo the vat handling
  • check for recaptcha : currently exist only if enabled for free/offline payments, can be configured for all the other payment cases too
  • check for invoice handling
  • ... ?
  • fix ui/ux of the stepper -> use a more material one

syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 remove term and condition links from reservation-page + handle t…
bb8f4a9 
…hem correctly after paypal redirect
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 fix test
e7db1ca
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import initial model changes
53328bf
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 import stubs for new flow
a8c0fe8
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 make the free flow work: still WIP
589b7a0
syjer added a commit that referenced this issue Jun 26, 2018
@syjer
#464 add text/breadcrumb
bfff8e7
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 remove payment form from the reservation-page.ms
26024da
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 enable stripe, refactor
4bbe045
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 re-enable paypal
cec1c53
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 remove term and condition links from reservation-page + handle t…
1086537 
…hem correctly after paypal redirect
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 fix test
3955356
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 re enable validation for step2, highlight errors
02ac16b
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 select label
7c8057a
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 reset form before cancel
9668331
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 split PaymentForm
9343b0e
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 initial work for mandatory invoice ui/ux
ef7b44f
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 hide billing fields for _not_ invoice only mode
4df0731
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 invoice available mode: show checkbox
1ad11d1
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 invoice available mode: invoice details section, initial work
c07d710
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 invoice details form
a001c48
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 translations
ba90ddd
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 translations
bb0b771
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 add vat nr input, wire up select country to vat nr label
dd9c523
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464 initial billing validation
836eed4
cbellone pushed a commit that referenced this issue Jul 2, 2018
@syjer @cbellone
New reservation flow (#484)
25ff546 
* #464 import initial model changes

* #464 import stubs for new flow

* #464 make the free flow work: still WIP

* #464 add text/breadcrumb

* #464 handle back, fix test

* #464 remove payment form from the reservation-page.ms

* #464 enable stripe, refactor

* #464 re-enable paypal

* #464 remove term and condition links from reservation-page + handle them correctly after paypal redirect

* #464 fix test

* #464 re enable validation for step2, highlight errors

* #464 select label

* #464 reset form before cancel

* #464 split PaymentForm

* #464 initial work for mandatory invoice ui/ux

* #464 hide billing fields for _not_ invoice only mode

* #464 invoice available mode: show checkbox

* #464 invoice available mode: invoice details section, initial work

* #464 invoice details form

* #464 translations

* #464 translations

* #464 add vat nr input, wire up select country to vat nr label

* #464 initial billing validation
syjer added a commit that referenced this issue Jul 2, 2018
@syjer
#464: remove info about old vat checker, remove client side check for…
ecbadf8 
… vatnr
syjer added a commit that referenced this issue Jul 4, 2018
@syjer
#464 reservation-page: add skip vat nr checkbox
84ed7b1
syjer added a commit that referenced this issue Jul 4, 2018
@syjer
#464 skip vat nr: added client side checks
a559fc2
syjer added a commit that referenced this issue Jul 4, 2018
@syjer
#464 re-wire up eu vat checking
5a3bc0b
syjer added a commit that referenced this issue Jul 5, 2018
@syjer
#464 set always false to vat exemption when doing the fallback valida…
6ebb86a 
…tion
syjer added a commit that referenced this issue Jul 5, 2018
@syjer
#464 add missing serializable, change text in top arrows when the eve…
7890a09 
…nt is free
syjer added a commit that referenced this issue Jul 5, 2018
@syjer
#464 use a more material-ish stepper
4cdd52f
syjer added a commit that referenced this issue Jul 8, 2018
@syjer
#464 re-enable captcha check
416aaed
@syjer
Copy link
Member Author

syjer commented Jul 8, 2018

can be considered done, note: translations are in a separate task.

@syjer syjer closed this as completed Jul 8, 2018
syjer added a commit that referenced this issue Jul 8, 2018
@syjer
#464 re-enable recaptcha for free of charge
a3a9cbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M0
Development

No branches or pull requests
1 participant
@syjer