Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize image on upload #527

Closed
syjer opened this issue Oct 5, 2018 · 0 comments
Closed

Resize image on upload #527

syjer opened this issue Oct 5, 2018 · 0 comments
Labels
enhancement

Comments

@syjer
Copy link
Member

syjer commented Oct 5, 2018

Currently when a user upload a logo, it will only check the size (in kb), but it may be problematic if the image is big in term of height x width.

Thus -> for images -> resize them on upload.
syjer added a commit that referenced this issue Oct 31, 2018
@syjer
#527 resize only if bigger than 500px
4711a8b
cbellone pushed a commit that referenced this issue Oct 31, 2018
@syjer @cbellone
Implement #527 resize image on upload (#538)
c6a666f 
* resize image on upload

* #527 resize only if bigger than 500px
cbellone pushed a commit that referenced this issue Oct 31, 2018
@syjer @cbellone
Implement #527 resize image on upload (#538)
2eea9ad 
* resize image on upload

* #527 resize only if bigger than 500px

(cherry picked from commit c6a666f)
@cbellone cbellone closed this as completed Nov 1, 2018
cbellone added a commit that referenced this issue Nov 1, 2018
@cbellone
#527 - keep original image format, otherwise the resulting size could…
501b6b7 
… be bigger than the original
cbellone added a commit that referenced this issue Nov 1, 2018
@cbellone
#527 - keep original image format, otherwise the resulting size could…
d6ab5d7 
… be bigger than the original

(cherry picked from commit 501b6b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syjer @cbellone