Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the vat term override in the configuration with a fixed selection. #640

Closed
syjer opened this issue May 6, 2019 · 1 comment
Closed

Comments

@syjer
Copy link
Member

syjer commented May 6, 2019

As a fix for #444, we added the possibility to override the term "VAT" to a specified value by the user.

This is confusing and when we will have a more general solution, it will be even more.

Replace the "Internationalization: Translations override" section with a radio button:

[ ] use VAT term, [ ] use GST term.

where both terms are defined in the properties as:

common.VAT = VAT
common.GST = GST

.

After that, we will expose the possibility to override all the keys

@syjer
Copy link
Member Author

syjer commented Jul 8, 2019

note, most likely will be superseded by #439

edit: (confirmed)

@syjer syjer closed this as completed Jul 8, 2019
cbellone pushed a commit that referenced this issue Jul 19, 2019
* wrap message source in a manager #439

* add new key for translation override #439

* inject the configuration repository in message source manager #439

* remove component annotation

* #439 add message source override support

* #439 cleanup, use @jsondata annotation

* #439 expose override props in event, cleanup

* #439 remove event language endpoint

* expose protected method resolveCode #439

* port translation_override_vat_* to new global translation override #439 #640

* #439 initial work for ui: add tab section for internationalization

* #439 remove i18n section in the main panel

* stub for internationalization-editor #439

* load configuration+all languages for internationalization-editor #439

* load bundle+ui work for internationalization-editor #439

* fix compile error #439

* translation ui work #439

* translation ui work #439

* make the ui submit update and delete translation #439

* add search #439

* display override from the previous level too #439

* rename sql file version, remove old conf key #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant