Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoice is not generated correctly when a discount is applied #661

Closed
salmar opened this issue Jun 14, 2019 · 0 comments
Closed

Invoice is not generated correctly when a discount is applied #661

salmar opened this issue Jun 14, 2019 · 0 comments
Milestone
2.0-M2

Comments

@salmar
Copy link
Contributor

salmar commented Jun 14, 2019

When a discount is applied to a ticket, the invoice contains a line item for the ticket and a second one for the discount. The price used for the ticket is the already discounted price but should be the original price. This creates confusion as it gives the impression that a discount should be applied to the already discounted ticket price.

To Reproduce
Steps to reproduce the behavior:

  1. Create a ticket with a discount and check the summary

Screenshot 2019-06-14 at 20 34 42

  1. Generate the invoice (if it's not already generated) and check the line item corresponding to the ticket doesn't match the summary on the reservation.

Screenshot 2019-06-14 at 20 32 43

Expected behavior
The invoice should use the original ticket price instead of the already discounted price

Receipts
If you generate a receipt instead of an invoice, it's generated correctly

Screenshot 2019-06-14 at 20 32 49
@syjer syjer added this to the 2.0-M2 milestone Jun 14, 2019
cbellone added a commit that referenced this issue Jun 14, 2019
@cbellone
Merge pull request #662 from salmar/661-incorrect-invoice
eea29e5 
Show correct ticket price on invoices #661
cbellone pushed a commit that referenced this issue Sep 15, 2019
@salmar @cbellone
Show VAT as included on invoices (#681)
46fcbbb 
* Added explicit cast to avoid type mismatch error

* Show correct ticket price on invoices #661

This commit fixed the issue with invoices with discounts. The invoice now shows the original ticket price instead of the already discounted price to be consistent with the reservation summary and receipts.

* Show VAT as included on invoices #661

Invoices show VAT (in case VAT should be shown), but when the amount already includes it, the invoices don’t mention it. This commit makes invoices differentiate between included and not included VAT when displaying it.

* Show VAT as included on invoices #661

Invoices show VAT (in case VAT should be shown), but when the amount already includes it, the invoices don’t mention it. This commit makes invoices differentiate between included and not included VAT when displaying it.

* Fixed summary price calculation

* Added license to SummaryPriceContainerTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
3 participants
@salmar @syjer @cbellone