Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check potential regression in m2: Category Tokens: if the reservation that had used a category token is cancelled in the admin it will remain PENDING #671

Closed
syjer opened this issue Jun 24, 2019 · 2 comments
Closed

check potential regression in m2: Category Tokens: if the reservation that had used a category token is cancelled in the admin it will remain PENDING #671

syjer opened this issue Jun 24, 2019 · 2 comments
Labels
bug
Milestone
2.0-M2

Comments

@syjer
Copy link
Member

syjer commented Jun 24, 2019

check potential regression in m2: Category Tokens: if the reservation that had used a category token is cancelled in the admin it will remain PENDING
@syjer syjer added the bug label Jun 24, 2019
@syjer syjer added this to the 2.0-M2 milestone Jun 24, 2019
@syjer
Copy link
Member Author

syjer commented Jun 24, 2019 •
edited
Loading

When calling in the admin:

AdminReservationManager.removeTicketsFromReservation is called.

In the normal folw:

TicketReservationManager.cleanupReferencesToReservation

who call:

specialPriceRepository.resetToFreeAndCleanupForReservation

syjer added a commit that referenced this issue Jun 24, 2019
@syjer
handle #671
6510083
@syjer
Copy link
Member Author

syjer commented Jun 25, 2019

fixed in commit 6510083

@syjer syjer closed this as completed Jun 26, 2019
syjer added a commit that referenced this issue Jun 26, 2019
@syjer
handle #671
312e41b
syjer added a commit that referenced this issue Jun 26, 2019
@syjer
handle #671
94663bc
cbellone pushed a commit that referenced this issue Jun 26, 2019
@syjer @cbellone
#657 implement code url (#670)
d2476b2 
* #657 initial stubs for code-url feature

* #657 add redirect from old url to api handler

* port old event code handling code #657

* refactor: move createticketreservation in a separate method #657

* refactor: remove unused payment callback controller #657

* misc refactor: use try with resource

* misc cleanup: remove unused code

* #657 remove unused code

* #657 refactor createTicketReservation

* #657 fallback locale

* enable partially the {code} functionality #657

* for {code} functionality: enable the case: restricted category+url code: disabled call to TicketReservationManager.renewSpecialPrice in flow #657

* disable tests #657

* add integration test for {code} for hidden category #657

* integration test: special price repository: check count #657

* handle #671

* refactor: remove specialPriceSessionId parameter #657

* refactor: remove specialPriceSessionId parameter #657

* refactor: remove specialPriceSessionId parameter+misc conf manager #657

* remove use of special price session id in admin reservation manager #657

* add test for reservation for hidden category #657

* remove last piece of sessionId in special price #657

* refactor: switch from Integer to int for param #657

* select for update skip locked for special price #657

* return binding result #657

* {code} flow: add query string for errors #657

* {code} flow: add query string for errors #657

* update frontend #657

* update frontend #657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
1 participant
@syjer