Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better defaults configuration values #731

Closed
syjer opened this issue Aug 27, 2019 · 1 comment
Closed

better defaults configuration values #731

syjer opened this issue Aug 27, 2019 · 1 comment
Assignees
@cbellone
Labels
breaking change This issue will introduce a breaking change enhancement
Milestone
2.0-M2

Comments

@syjer
Copy link
Member

syjer commented Aug 27, 2019

Some of the defaults configuration/parameters seems to be counter intuitive:

  • A sizeable amount of users prefer to don't have the expired offline payment reservations removed by the jobs.
  • Same for expired reservations created by the Admin

Check and update accordingly.
@syjer syjer added this to the 2.0-M2 milestone Aug 27, 2019
@syjer syjer added the breaking change This issue will introduce a breaking change label Aug 30, 2019
cbellone added a commit to cbellone/alf.io that referenced this issue Oct 20, 2019
@cbellone
alfio-event#731 - set default false for AUTOMATIC_REMOVAL_EXPIRED_OFF…
0a7aeb8 
…LINE_PAYMENT
cbellone added a commit to cbellone/alf.io that referenced this issue Oct 20, 2019
@cbellone
alfio-event#731 - fix test
4d9376f
@cbellone cbellone mentioned this issue Oct 20, 2019
Merged
syjer pushed a commit that referenced this issue Oct 20, 2019
@cbellone @syjer
Misc fixes (#805)
4a65874 
* remove serializer and transform dates directly

* #731 - set default false for AUTOMATIC_REMOVAL_EXPIRED_OFFLINE_PAYMENT

* #731 - fix test

* remove unused test

* re-enable test

* remove unused test

* fix warnings
@cbellone
Copy link
Member

expired offline payments are now deleted only if the flag is explicitly set to false.

@cbellone cbellone mentioned this issue Oct 20, 2019
Closed
cbellone added a commit to cbellone/alf.io that referenced this issue Oct 20, 2019
@cbellone
alfio-event#731 - tickets must be assigned by default
4fe6b29
syjer pushed a commit that referenced this issue Oct 20, 2019
@cbellone @syjer
update layout + messages + validation (#807)
64e5083 
* #731 - tickets must be assigned by default

* update text

* #786 - basic email validation

* update frontend version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbellone cbellone

Labels
breaking change This issue will introduce a breaking change enhancement
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
2 participants
@syjer @cbellone