Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#153 add option to indicate mandatory/optional for additional fields #198

Closed
wants to merge 1 commit into from
Closed

#153 add option to indicate mandatory/optional for additional fields #198

wants to merge 1 commit into from

Conversation

Praitheesh
Copy link
Contributor

@Praitheesh Praitheesh commented Sep 5, 2016

#153 add option to indicate mandatory/optional in admin panel and validate on ticket reservation page

@coveralls
Copy link

coveralls commented Sep 5, 2016

Coverage Status

Coverage decreased (-0.01%) to 54.271% when pulling bf0636a on Praitheesh:153_optional_mandatory_field into d29ad9d on exteso:master.

@Praitheesh
Copy link
Contributor Author

@syjer please review and let me know if any changes required. Thanks.

@syjer
Copy link
Member

syjer commented Sep 5, 2016

Thanks for the pull request @Praitheesh ! Globally it seems ok, what it's currently missing is the server side validation

@cbellone
Copy link
Member

Hi @Praitheesh,

while working on #212 I had to modify the assign-ticket-form page.
Could you please rebase your modifications so that I can merge your pull request, add the server side validation and close #153 ?

Thanks!
Celestino

@Praitheesh Praitheesh closed this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants