Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement #431 #437

Merged
merged 7 commits into from May 19, 2018
Merged

implement #431 #437

merged 7 commits into from May 19, 2018

Conversation

syjer
Copy link
Member

@syjer syjer commented May 18, 2018

Implement the customization of the "VAT" term.

Don't merge it right now as it may have some stuff that I've forgotten :P.

@syjer syjer requested a review from cbellone May 18, 2018 21:03
@coveralls
Copy link

coveralls commented May 19, 2018 •
edited

Coverage Status

Coverage increased (+0.07%) to 51.043% when pulling ec2a791 on 431-add-vat-term-override into 260fc16 on master.

cbellone
cbellone approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@cbellone cbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@syjer syjer merged commit 8e422af into master May 19, 2018
syjer added a commit that referenced this pull request May 19, 2018
@syjer
implement #431 (#437)
63139ac 
* #431 add new keys

* #431 add common term in translation files

* #431 add initial vat override

* #431 continue vat term override: add support for templates too

* #431 finish up the translations/template update

* #431 move translations configuration key in a specific category

* #431 fix test
stephanj added a commit to devoxx/alf.io that referenced this pull request May 19, 2018
@stephanj
Merge pull request #1 from alfio-event/1.14-maintenance
2a7e117 
implement alfio-event#431  (alfio-event#437)
@syjer syjer deleted the 431-add-vat-term-override branch May 25, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbellone cbellone cbellone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@syjer @coveralls @cbellone