Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker Compose support #534

Merged
merged 6 commits into from Oct 27, 2018
Merged

Add Docker Compose support #534

merged 6 commits into from Oct 27, 2018

Conversation

asymmetric
Copy link
Contributor

Closes #363.

cbellone
cbellone requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@cbellone cbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asymmetric, thank you for your PR :)

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
cbellone and others added 3 commits October 17, 2018 12:13
@cbellone @asymmetric
docker: use latest image
c0d79d8
@asymmetric
docker: remove mapping for HTTPS
4e0d004 
It's not supported during development, so it doesn't make sense to have
it in the docker-compose.yml.
@asymmetric
docker: map port 8080 in container to 8080 on host
84b5b34
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 53.178% when pulling 84b5b34 on asymmetric:asymmetric/docker-compose into c17a575 on alfio-event:master.

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited

Coverage Status

Coverage remained the same at 53.186% when pulling 5f72af7 on asymmetric:asymmetric/docker-compose into c17a575 on alfio-event:master.

@asymmetric
Copy link
Contributor Author

Can coveralls be configured with thresholds? -0.008% seems hardly relevant :)

@asymmetric
docker: enable jdbc-session profile
5f72af7 
So that sessions persist across container restarts.
@asymmetric
Copy link
Contributor Author

asymmetric commented Oct 17, 2018 •
edited

PTALA (please take a look again).

@cbellone cbellone merged commit 66f2377 into alfio-event:master Oct 27, 2018
@cbellone
Copy link
Member

merged. Thank you! 👍

@asymmetric asymmetric deleted the asymmetric/docker-compose branch October 27, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbellone cbellone cbellone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @coveralls @cbellone