Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#469 add row security policy #567

Merged
merged 45 commits into from
Dec 27, 2018
Merged

#469 add row security policy #567

merged 45 commits into from
Dec 27, 2018

Conversation

syjer
Copy link
Member

@syjer syjer commented Dec 21, 2018

implement #469 .

Note, the refactor of the web controllers will be done in the M2 phase, in issue #566

@syjer syjer added this to the 2.0-M1 milestone Dec 21, 2018
@syjer syjer requested a review from cbellone December 21, 2018 15:59
@coveralls
Copy link

coveralls commented Dec 21, 2018

Coverage Status

Coverage decreased (-0.1%) to 53.431% when pulling ed5dd4a on 469-add-row-security-policy into 323c15d on master.

//
}

if (log.isDebugEnabled()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be better to print these information at a TRACE level

sb.append("-----------\n");
}

log.debug(sb.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above, better if TRACE

@cbellone cbellone merged commit 83d3716 into master Dec 27, 2018
@syjer syjer deleted the 469-add-row-security-policy branch January 10, 2019 14:02
@syjer syjer restored the 469-add-row-security-policy branch January 10, 2019 14:02
@syjer syjer deleted the 469-add-row-security-policy branch January 10, 2019 14:03
@syjer syjer restored the 469-add-row-security-policy branch January 10, 2019 14:03
@syjer syjer deleted the 469-add-row-security-policy branch June 27, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants