Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java-object-diff #746

Merged
merged 3 commits into from
Sep 8, 2019
Merged

Remove java-object-diff #746

merged 3 commits into from
Sep 8, 2019

Conversation

syjer
Copy link
Member

@syjer syjer commented Sep 7, 2019

Work in progress.

Remove the java-object-diff library. We are only using for 2 cases, diffing objects with the same type and with only 1 level.

We can do it with few lines of code and avoid some runtime warning (WARNING: Illegal reflective access by de.danielbechler.util.Classes)

@syjer syjer added this to the 2.0-M2 milestone Sep 7, 2019
@syjer syjer requested a review from cbellone September 7, 2019 17:25
@coveralls
Copy link

coveralls commented Sep 7, 2019

Coverage Status

Coverage increased (+0.09%) to 56.53% when pulling 2711084 on remove-java-object-diff into 4bca3bf on master.

@syjer syjer marked this pull request as ready for review September 8, 2019 13:51
@syjer
Copy link
Member Author

syjer commented Sep 8, 2019

ready to be reviewed and merged.

@cbellone cbellone merged commit 66112a3 into master Sep 8, 2019
@syjer syjer deleted the remove-java-object-diff branch September 10, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants