Detect Asynchronous Events + More #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test fails for different reasons in different runs Co-authored-by: Mark Alexander Bis <35311810+MarkBis415@users.noreply.github.com> Co-authored-by: Rogelio Macedo <32654086+rmace001@users.noreply.github.com>
* add asynchronous extension to database
* detect logs after RESERVATION_CONFIRMED
* lay-out steps to perform future tests on extensions that have been fired
* Includes clearing extension_log table before asserting what logs are present
Co-authored-by: Mark Alexander Bis <35311810+MarkBis415@users.noreply.github.com>
Co-authored-by: Alexander Yee <32520269+YeeitsAlex@users.noreply.github.com>
* RESERVATION_CONFIRMED is an asynchronous event (test by inserting asynchronous extension)
* Find all RESERVATION_CONFIRMED
* There is only one log(warn) from script with event: RESERVATION_CONFIRMED
* Clear the extension_log table whenever we assert for presence of log
* Each time an event is logged, we expect to find exactly two logs for the event
Co-authored-by: Mark Alexander Bis <35311810+MarkBis415@users.noreply.github.com>
Co-authored-by: Alexander Yee <32520269+YeeitsAlex@users.noreply.github.com>
Co-authored-by: Mark Alexander Bis <35311810+MarkBis415@users.noreply.github.com> Co-authored-by: Alexander Yee <32520269+YeeitsAlex@users.noreply.github.com>
cbellone
approved these changes
Mar 12, 2020
|
Merged. Thank you guys, great job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ReservatioFlowIntegrationTest, add an asynchronous extension to the database to enable detectingRESERVATION_CONFIRMED(an asynchronous event). We clear the extension_log table whenever we assert for presence of log. This PR also tests forRESERVATION_CANCELLED,TICKET_ASSIGNED, andTICKET_CHECKED_IN. Each time an event is logged, we expect to find exactly two logs for the event.Find all RESERVATION_CONFIRMED
log(WARN) from script with event: RESERVATION_CONFIRMEDin the test output