Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety migration #12

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Null safety migration #12

merged 3 commits into from
Apr 23, 2021

Conversation

sunderee
Copy link

This pull request addresses migration to Dart's new safety feature and it brings many improvements related to lint rules which haven't been followed thus far (for instance, preferring var).

@pawelpetruch
Copy link

@alfonsocejudo can you merge this and publish a new pub.dev?

Copy link
Owner

@alfonsocejudo alfonsocejudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nicely done

@alfonsocejudo alfonsocejudo merged commit 396e8bc into alfonsocejudo:master Apr 23, 2021
@PaoloP98
Copy link

PaoloP98 commented Apr 24, 2021

I have an error using the null safety version

E/flutter ( 687): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type '(BaseCluster, double, double) => MapMarker' is not a subtype of type '((BaseCluster?, double?, double?) => MapMarker)?'

I initialised the cluster in this way:

      minZoom: minZoom,
      maxZoom: maxZoom,
      radius: 150,
      extent: 4096,
      nodeSize: 64,
      points: markers,
      createCluster: (
        BaseCluster cluster,
        double lng,
        double lat,
      ) =>
          MapMarker(
        id: cluster.id.toString(),
        latitude: lat,
        longitude: lng,
        isCluster: cluster.isCluster,
        clusterId: cluster.id,
        pointsSize: cluster.pointsSize,
        childMarkerId: cluster.childMarkerId,
      ),
    );

Do you know what the problem is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants