ESC key does not work on Windows

[GGGO]

Hi,

on Windows, I can't use ESC key. So it's impossible to cancel any dialing/refer prompt, and to hangup/reject a call with ESC key.

Here a patch for modules/wincons/wincons.c in input_thread():

 static DWORD WINAPI input_thread(LPVOID arg)
 {
        struct ui_st *st = arg;
@@ -85,23 +95,25 @@

        while (st->run) {

-               char buf[4];
+               INPUT_RECORD buf[4];
                DWORD i, count = 0;

-               ReadConsole(st->hstdin, buf, sizeof(buf), &count, NULL);
+               ReadConsoleInput(st->hstdin, buf, sizeof(buf), &count);

                for (i=0; i<count; i++) {
-                       int ch = buf[i];
-
-                       if (ch == '\r')
-                               ch = '\n';
-
-                       /*
-                        * The keys are read from a thread so we have
-                        * to send them to the RE main event loop via
-                        * a message queue
-                        */
-                       mqueue_push(st->mq, ch, 0);
+                       if (buf[i].EventType == KEY_EVENT) {
+                               if (buf[i].Event.KeyEvent.bKeyDown) {
+                                       int ch = buf[i].Event.KeyEvent.uChar.AsciiChar;
+
+                                       if (ch == '\r')
+                                               ch = '\n';
+
+                                       /*
+                                        * The keys are read from a thread so we have
+                                        * to send them to the RE main event loop via
+                                        * a message queue
+                                        */
+                                       mqueue_push(st->mq, ch, 0);
+                               }
+                       }
                }
        }

In the TODO, I can see "improve gui and multi-UA and multi-call interaction", is someone working on this or got some ideas how to implement it ?

Right now, it's impossible to select or switch from many call.

Thanks.

[alfredh]

thanks @GGGO for the patch, it was commit to master (with minor adjustments).

regarding improving the GUI there are plans to do it, and I think we need input from
community regarding how it should work. For example we should add long-string commands
because the single key command space is "used up" ..

example:

'd'    "dial"                Dial remote uri
's'    "sysinfo"             Print system info
       "load_module"         Load a module

[seven1240]

I think it's two topics so I created #140 and #141