Fix/multi input is not a function #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alfredosalzillo
commented
Jul 4, 2024
alfredosalzillo
commented
- updated deps
- added test for rollup4
- use node 20 in CI/CD pipeline
- set project as module (solve TypeError: multiInput is not a function #61)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 28 28
Branches 5 5
=========================================
Hits 28 28 Continue to review full report in Codecov by Sentry.
|
alfredosalzillo
force-pushed
the
fix/multi-input-is-not-a-function
branch
2 times, most recently
from
fe71e02
to
6d0c809
Compare
alfredosalzillo
force-pushed
the
fix/multi-input-is-not-a-function
branch
from
6d0c809
to
69c822a
Compare
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wridgeu
added a commit
to wridgeu/chrome-extension-video-playbackrate
that referenced
this pull request
Jul 7, 2024
- now uses UI5 web components 2.0 - uses type imports where necessary - some getElementById calls are now typed against the UI5 components - adjusts rollup plugin multiInput usage thanks to the fix in alfredosalzillo/rollup-plugin-multi-input#80 - adjusts rimraf cli usage due to version changes, see also: https://stackoverflow.com/a/75309179/10323879 for a tldr; - renamed the default checkbox text - removed obsolete theme support (dev side) - removed deprecated "install" command from husky - remove obsolete eslintignore file and move ignored files to main config - complete move to eslint flatconfig - file linting and minor code adjustments - version bumps across the board comments: - some of the linting was using biome (as plugin) - I could add biome natively to the project and get rid of eslint, would be nice but not necessary for now - still manually bumping the versions for now, might add semver later on - may try out some other bundlers/tools ... what if instead of using raw rollup I could try swc, vite?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.