Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared files - broken link #3

Open
howkymike opened this issue May 11, 2022 · 0 comments
Open

Shared files - broken link #3

howkymike opened this issue May 11, 2022 · 0 comments

Comments

@howkymike
Copy link

howkymike commented May 11, 2022

MNT-22612 commit introduced a bug, where a document-details button link in the shared page is invalid - "example.com/share/s/Encode.forHtmlAttribute(/share/page/quickshare-redirect?id=XXX)"

Proposed change in the share/src/main/resources/alfresco/site-webscripts/org/alfresco/components/quickshare/header.get.html.ftl line 32:
<a href="${linkButton.href?xhtml}" class="brand-button ${linkButton.cssClass!""}" tabindex="0">${linkButton.label?xhtml}</a>

I guess @rrajoria tried to used OWASP Encode utility but it is not available on the Freemakrer's side. Such an expression should also be inside Freemarker's expression ${}. Anyway, ?xhtml should be enough to protect against XSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant