Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize non-ACGT and then build colors by --load-dbg may fail? #18

Open
jnalanko opened this issue Sep 19, 2022 · 0 comments
Open

Randomize non-ACGT and then build colors by --load-dbg may fail? #18

jnalanko opened this issue Sep 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jnalanko
Copy link
Collaborator

When using the randomization for non-ACGT characters without building colors, and building colors again on another run, the program should crash because if we don't get exactly the same random choices, some of the k-mers will change and this messes up the coloring. But at the moment it works because we don't give a seed value for std::rand so according to the standard it will always be seeded with the value 1. No other piece of code uses std::rand before the coloring so by luck we happen to get the random choices. But this might break in the future, so it should be fixed.

@jnalanko jnalanko added the bug Something isn't working label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant