Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 decimals for number is not remembered #23

Closed
bijwaard opened this issue Jun 25, 2019 · 9 comments
Closed

0 decimals for number is not remembered #23

bijwaard opened this issue Jun 25, 2019 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@bijwaard
Copy link

I can successfully change the decimals for number type under Mapping. However, when I set it to 0 decimals, save and switch dashboard it is back to the default 2 decimals.

@algenty
Copy link
Owner

algenty commented Jun 25, 2019

thanks for your feedback
which is your version ?

@bijwaard
Copy link
Author

This is with the 0.40 snapshot

@algenty
Copy link
Owner

algenty commented Jun 25, 2019

ok i'll try to reproduce it and i come back

@algenty algenty added the bug Something isn't working label Jun 25, 2019
@algenty algenty self-assigned this Jun 25, 2019
@algenty
Copy link
Owner

algenty commented Jul 10, 2019

Lol, i found the problem,
I dont understand, first i try with 5 decimals and it's work.
In the code, i have this.data.decimals = obj.decimals || 2;
if decimal = 0, javascript understand false then it takes 2 by default.
I test and i build a snapshot

@bijwaard
Copy link
Author

I prefer some stricter typing such as in C++ and python3.x;-)
Guess you would need a more precise handling of the non-existence of obj.decimals. Hope that fixes it.

@algenty
Copy link
Owner

algenty commented Jul 14, 2019

Hi @bijwaard,
Decimal is fixed in new snapshot version
https://algenty.github.io/flowcharting-repository/ARCHIVES.html
Tooltip with metrics added in this version

BR,
Arnaud

@bijwaard
Copy link
Author

bijwaard commented Jul 14, 2019 via email

@algenty algenty closed this as completed Jul 14, 2019
@bijwaard
Copy link
Author

just verified that the fix appears to work in the new snapshot, great work!

@algenty
Copy link
Owner

algenty commented Jul 18, 2019

you're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants