Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor openssl to crypto #449

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Refactor openssl to crypto #449

merged 15 commits into from
Jan 23, 2024

Conversation

algesten
Copy link
Owner

  • Reword expect
  • Remove ToRtpIv trait for aes_128_cm_sha1_80
  • Remove ToRtpIv trait for aead_aes_128_gcm
  • Move KeyingMaterial out of ossl module
  • Add CI check for --no-default-features
  • crypto.rs -> crypto/mod.rs
  • Refactor OpenSSL DTLS into crypto mod
  • Feature gate openssl
  • Move things around in crypto
  • Refactor our SRTP crypto
  • Feature gate all openssl

@algesten algesten mentioned this pull request Jan 23, 2024
Closed
k0nserv
k0nserv approved these changes Jan 23, 2024
View reviewed changes
src/crypto/dtls.rs Show resolved Hide resolved
src/crypto/dtls.rs Show resolved Hide resolved
src/crypto/ossl/dtls.rs Show resolved Hide resolved
src/crypto/ossl/mod.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments as food for thought! Nothing blocking :)

src/crypto/dtls.rs Outdated Show resolved Hide resolved
src/crypto/finger.rs Outdated Show resolved Hide resolved
src/crypto/srtp.rs Outdated Show resolved Hide resolved
src/crypto/dtls.rs Show resolved Hide resolved
src/crypto/srtp.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@thomaseizinger thomaseizinger mentioned this pull request Jan 23, 2024
Closed
@algesten algesten merged commit fdb02cf into main Jan 23, 2024
20 checks passed
@algesten algesten deleted the feature/crypto-refactor branch January 23, 2024 19:32
@thomaseizinger
Copy link
Collaborator

Thank you for acting on this so quickly! 🎉

@algesten
Copy link
Owner Author

No worries. I want you to get real world usage out of the ICE Agent, so we can start improving that part together! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnorpx xnorpx xnorpx left review comments

@k0nserv k0nserv k0nserv approved these changes

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@lolgesten lolgesten lolgesten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@algesten @thomaseizinger @xnorpx @k0nserv @lolgesten