Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a const fn to compute the overall STUN timeout #462

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix: use a const fn to compute the overall STUN timeout #462

merged 3 commits into from
Feb 20, 2024

Conversation

thomaseizinger
Copy link
Collaborator

No description provided.

@thomaseizinger thomaseizinger marked this pull request as draft February 19, 2024 07:44
@thomaseizinger thomaseizinger marked this pull request as ready for review February 19, 2024 07:53
algesten
algesten approved these changes Feb 19, 2024
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks!

@thomaseizinger thomaseizinger marked this pull request as draft February 19, 2024 07:58
@thomaseizinger
Copy link
Collaborator Author

I pushed another version where I am just testing the constant. Less invasive.

What do you prefer?

@algesten
Copy link
Owner

Neat.

I did like the test in the previous as well :)

@thomaseizinger
Copy link
Collaborator Author

I am leaning towards just testing the constant until we get better const arithemtic support :)

@thomaseizinger thomaseizinger marked this pull request as ready for review February 20, 2024 11:31
@algesten algesten merged commit 3c2eeb5 into algesten:main Feb 20, 2024
22 checks passed
@algesten
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaseizinger @algesten