Implement VP9 PayloadParams fuzzy matching
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, VP9 is only matched by exact match, leading to potential issues with sessions in Chrome and Firefox browsers. The problem arises from Firefox not setting the
profile_id, causing str0m to interpret Firefox'sPayloadParamsas incompatible with Chrome. According to the VP9 specification, whenprofile_idis unset, it should default to0. This pull request addresses this issue by implementing the functionality to defaultprofile_idto0in the fuzzy match of VP9.draft-ietf-payload-vp9-16#section-6