Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit "Lazily enable nack timeouts" (f72b690) was introduced optimization of NACK timeouts enabling, this commit added
Streams::any_nack_enabled
resetting inStreams::stream_rx_by_mid_rid()
, butStreams
has exact the same method calledStreams::rx_by_mid_rid
(which is used under the hood inDirect::stream_rx_by_mid
) which wasn't updated. So if you're gettingStreamRx
from Direct API and callsuppress_nack(false)
on it, thenany_nack_enabled
is not updated, resulting in NACKs not being transmitted.This PR removes this duplication of methods
rx_by_mid_rid
andtx_by_mid_rid
in favor ofstream_tx_by_mid_rid
andstream_rx_by_mid_rid
.