Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy NACK timeouts enabling #501

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

evdokimovs
Copy link
Contributor

In commit "Lazily enable nack timeouts" (f72b690) was introduced optimization of NACK timeouts enabling, this commit added Streams::any_nack_enabled resetting in Streams::stream_rx_by_mid_rid(), but Streams has exact the same method called Streams::rx_by_mid_rid (which is used under the hood in Direct::stream_rx_by_mid) which wasn't updated. So if you're getting StreamRx from Direct API and call suppress_nack(false) on it, then any_nack_enabled is not updated, resulting in NACKs not being transmitted.

This PR removes this duplication of methods rx_by_mid_rid and tx_by_mid_rid in favor of stream_tx_by_mid_rid and stream_rx_by_mid_rid.

@algesten algesten marked this pull request as ready for review April 22, 2024 13:08
@algesten
Copy link
Owner

Oh wow. This is a big 🤦 :D

@algesten algesten merged commit 9a04867 into algesten:main Apr 22, 2024
22 checks passed
@algesten
Copy link
Owner

Thanks!

@evdokimovs evdokimovs deleted the fix-nack-optimization branch April 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants