Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hootbin is a required dependency #724

Closed
kolbma opened this issue Feb 9, 2024 · 2 comments · Fixed by #729
Closed

hootbin is a required dependency #724

kolbma opened this issue Feb 9, 2024 · 2 comments · Fixed by #729

Comments

@kolbma
Copy link

kolbma commented Feb 9, 2024

Can't you move your doc tests to unit tests where hootbin is used?!
It pulls in serde/serde_json and fastrand dependency in productive code, because of your doc tests...

c4e0b36
@algesten
Copy link
Owner

#703 (comment)

@algesten algesten changed the title Throw hootbin out of your doc tests hootbin is a required dependency Feb 16, 2024
@algesten algesten mentioned this issue Feb 16, 2024
Merged
@kolbma
Copy link
Author

kolbma commented May 11, 2024

@algesten Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testdeps feature to pull in hootbin when needed algesten/ureq
2 participants
@algesten @kolbma