testdeps feature to pull in hootbin when needed #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
force-pushed
the
fix/testdeps
branch
from
cbd8cf7
to
4a21d90
Compare
This PR makes it so tests must run using the `testdeps` feature. That means hootbin can be an optional dependency and thus not being a forced dependency on our users.
algesten
force-pushed
the
fix/testdeps
branch
from
4a21d90
to
46c4898
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so tests must run using the
testdepsfeature. That means hootbin can be an optional dependency
and thus not being a forced dependency on our users.
Close #724
Relates to #703