Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: empty comment lines? #97

Closed
jsha opened this issue Jun 27, 2020 · 2 comments
Closed

style: empty comment lines? #97

jsha opened this issue Jun 27, 2020 · 2 comments

Comments

@jsha
Copy link
Collaborator

jsha commented Jun 27, 2020

I had a question about coding style. I noticed there are a bunch of empty comments, like so:

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        //
        let line = s.to_string();

Are these meant to denote something? Should I clean them up?

@algesten
Copy link
Owner

@jsha this is a quirk I have. 🙈

I use cargo fmt bound to quick-keys in my editor, and I use it all the time, however I have a love/hate relationship to code formatters. One thing I can't quite abide by is not allowing me to have some space between the function declaration and the first row. I struggle to see where the declaration ends and the code starts.

I'm not going to be precious about them however. It's a shared code base and it's better without my idiosyncrasies. Remove if you want!

@jsha
Copy link
Collaborator Author

jsha commented Jun 30, 2020

No problem! I am a big fan of cargo fmt.

@jsha jsha closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants