Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rework the Metadata Provider #202

Open
c-harris opened this issue Dec 31, 2017 · 2 comments
Open

Need to rework the Metadata Provider #202

c-harris opened this issue Dec 31, 2017 · 2 comments

Comments

@c-harris
Copy link
Member

The simple metadata provider was some time replaced by the metadataManager in the o-data-metadata package. but the Simplemetadata provider was left as a wrapper around that class. as such it probably needs to be reworked so it is a complete wrapper around the metadata manager and the rest of POData use the the objects in o-data-metadata.

Because this is likely to lead to an interface change i would like to give some time for other people using the project to have some input on how the provider should work and changes in the interface. specifically @cdcampos i believe you are probably using the provider directly so your input would be appreciated.

@cdcampos
Copy link

cdcampos commented Jan 2, 2018

Not sure what you mean by direct use of SimpleMetadataProvider. In my services I create an instance of this class, on which I then call the add* methods for the different components (types, sets, associations). The instance is then supplied in the second parameter of SimpleDataService.

I don't use any method from interface IMetadataProvider.

@CyberiaResurrection
Copy link
Collaborator

@cdcampos, I think @c-harris is referring to an API change in general, not to changing any specific interface (IMetadataProvider, IZoidberg, IRobot, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants