Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize topic and subscription separator #80

Merged
merged 5 commits into from
Dec 26, 2020
Merged

Conversation

mts88
Copy link

@mts88 mts88 commented Dec 24, 2020

Description

Provides option to customize topic and subscription separator, if topic or subscription prefix is provided

Motivation and Context

In some cases, using others programming languages and others libraries, it's necessary to maintain same pattern of {sub prefix}{sub separator}{topic name}. In this way you can customize each parts of subscription name's pattern.
Requested in #78

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

MTS added 5 commits December 24, 2020 17:44
…tween prefix and topic name

Added support to customize separator between subscriptions prefix and topic name

feat algoan#78
Topic name of tests GPS005 and GPS006 was still used. Replaced with new ones
…ption separator

Fixed default value subscription separator
Customize topic separator between topic prefix and topic name
@mts88 mts88 changed the title Customize subscription separator Customize topic and subscription separator Dec 24, 2020
@ccoeurderoy ccoeurderoy self-requested a review December 26, 2020 11:33
@ccoeurderoy ccoeurderoy added the enhancement New feature or request label Dec 26, 2020
Copy link
Collaborator

@ccoeurderoy ccoeurderoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@ccoeurderoy ccoeurderoy merged commit f26e007 into algoan:master Dec 26, 2020
@algoanbot
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants