fix(builder): Rename builder.setExtraHeader => `builder.addExtraHea…

…der` Closes #433
algolia · Jan 23, 2018 · bb97acc · bb97acc
1 parent f0385ee
commit bb97acc
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 16 deletions.
diff --git a/algoliasearch-appengine/src/main/java/com/algolia/search/AppEngineAPIClientBuilder.java b/algoliasearch-appengine/src/main/java/com/algolia/search/AppEngineAPIClientBuilder.java
@@ -23,11 +23,17 @@ public AppEngineAPIClientBuilder setUserAgent(
   }
 
   @Override
+  @Deprecated
   public AppEngineAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
     super.setExtraHeader(key, value);
     return this;
   }
 
+  @Override
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
+    return super.addExtraHeader(key, value);
+  }
+
   @Override
   public AppEngineAPIClientBuilder setConnectTimeout(int connectTimeout) {
     super.setConnectTimeout(connectTimeout);

diff --git a/algoliasearch-async/src/main/java/com/algolia/search/AsyncHttpAPIClientBuilder.java b/algoliasearch-async/src/main/java/com/algolia/search/AsyncHttpAPIClientBuilder.java
@@ -23,11 +23,17 @@ public AsyncHttpAPIClientBuilder setUserAgent(
   }
 
   @Override
+  @Deprecated
   public AsyncHttpAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
     super.setExtraHeader(key, value);
     return this;
   }
 
+  @Override
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
+    return super.addExtraHeader(key, value);
+  }
+
   @Override
   public AsyncHttpAPIClientBuilder setConnectTimeout(int connectTimeout) {
     super.setConnectTimeout(connectTimeout);

diff --git a/algoliasearch-common/src/main/java/com/algolia/search/APIClientBuilder.java b/algoliasearch-common/src/main/java/com/algolia/search/APIClientBuilder.java
@@ -32,19 +32,17 @@ public APIClientBuilder setUserAgent(
     return this;
   }
 
-  /**
-   * Set extra headers to the requests
-   *
-   * @param key name of the header
-   * @param value value of the header
-   * @return this
-   */
   @Override
   public APIClientBuilder setExtraHeader(@Nonnull String key, String value) {
     super.setExtraHeader(key, value);
     return this;
   }
 
+  @Override
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
+    return super.addExtraHeader(key, value);
+  }
+
   /**
    * Set the connect timeout of the HTTP client
    *

diff --git a/algoliasearch-common/src/main/java/com/algolia/search/AsyncAPIClientBuilder.java b/algoliasearch-common/src/main/java/com/algolia/search/AsyncAPIClientBuilder.java
@@ -34,19 +34,18 @@ public AsyncAPIClientBuilder setUserAgent(
     return this;
   }
 
-  /**
-   * Set extra headers to the requests
-   *
-   * @param key name of the header
-   * @param value value of the header
-   * @return this
-   */
   @Override
+  @Deprecated
   public AsyncAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
     super.setExtraHeader(key, value);
     return this;
   }
 
+  @Override
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
+    return super.addExtraHeader(key, value);
+  }
+
   /**
    * Set the connect timeout of the HTTP client
    *

diff --git a/algoliasearch-common/src/main/java/com/algolia/search/GenericAPIClientBuilder.java b/algoliasearch-common/src/main/java/com/algolia/search/GenericAPIClientBuilder.java
@@ -58,14 +58,21 @@ public GenericAPIClientBuilder setUserAgent(
     return this;
   }
 
+  /** Deprecated: use {@link #addExtraHeader(String, String)} */
+  @Deprecated
+  public GenericAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
+    customHeaders.put(key, value);
+    return this;
+  }
+
   /**
-   * Set extra headers to the requests
+   * Add extra headers to the requests
    *
    * @param key name of the header
    * @param value value of the header
    * @return this
    */
-  public GenericAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
     customHeaders.put(key, value);
     return this;
   }

diff --git a/algoliasearch/src/main/java/com/algolia/search/ApacheAPIClientBuilder.java b/algoliasearch/src/main/java/com/algolia/search/ApacheAPIClientBuilder.java
@@ -18,11 +18,17 @@ public ApacheAPIClientBuilder setUserAgent(
   }
 
   @Override
+  @Deprecated
   public ApacheAPIClientBuilder setExtraHeader(@Nonnull String key, String value) {
     super.setExtraHeader(key, value);
     return this;
   }
 
+  @Override
+  public GenericAPIClientBuilder addExtraHeader(@Nonnull String key, String value) {
+    return super.addExtraHeader(key, value);
+  }
+
   @Override
   public ApacheAPIClientBuilder setConnectTimeout(int connectTimeout) {
     super.setConnectTimeout(connectTimeout);