-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2.22.0) Adds: missing query parameters #600
Conversation
cc48eee
to
03e0ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, thank you Antoine!
Only comment but maybe too late: we could have split this in multiple commits (one of each type added/changed and one for the tests) and some for the tests. This way, once we generate the ChangeLog entry, we could directly let users see what has changed (especially as we are introducing breaking changes). WDYT?
.collect(Collectors.joining(",")) | ||
+ "]") | ||
.collect(Collectors.joining(",")) | ||
+ "]"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this style is enforced by coveo
but it is particularly difficult to read. May we try to change that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's coveo styling convention and I couldn't find a way to change it.
Breaking change: - numericFilters is now List<List<String>> instead of List<String> - tagFilters is now List<List<String>> instead of List<String> - analyticsTags is now List<String> instead of String. This is also adding support for nested list when serializing the query as urlParameters.
03e0ec1
to
a7ac8c6
Compare
a7ac8c6
to
be6d301
Compare
Fix #599