(2.22.0) Adds: missing query parameters #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ant-hem
force-pushed
the
missing-params-v2
branch
2 times, most recently
from
cc48eee
to
03e0ec1
Compare
aseure
reviewed
Jul 10, 2019
There was a problem hiding this comment.
Great changes, thank you Antoine!
Only comment but maybe too late: we could have split this in multiple commits (one of each type added/changed and one for the tests) and some for the tests. This way, once we generate the ChangeLog entry, we could directly let users see what has changed (especially as we are introducing breaking changes). WDYT?
| .collect(Collectors.joining(",")) | ||
| + "]") | ||
| .collect(Collectors.joining(",")) | ||
| + "]"; |
There was a problem hiding this comment.
I don't know if this style is enforced by coveo but it is particularly difficult to read. May we try to change that?
There was a problem hiding this comment.
It's coveo styling convention and I couldn't find a way to change it.
Breaking change: - numericFilters is now List<List<String>> instead of List<String> - tagFilters is now List<List<String>> instead of List<String> - analyticsTags is now List<String> instead of String. This is also adding support for nested list when serializing the query as urlParameters.
Ant-hem
force-pushed
the
missing-params-v2
branch
from
03e0ec1
to
a7ac8c6
Compare
aseure
approved these changes
Jul 10, 2019
Ant-hem
force-pushed
the
missing-params-v2
branch
from
a7ac8c6
to
be6d301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #599