fix(client): Add one deleteIndex method (#427) #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElPicador
suggested changes
Feb 13, 2018
| @@ -232,6 +232,24 @@ public Task copyIndex( | |||
| return copyIndex(srcIndexName, dstIndexName, scopes, RequestOptions.empty); | |||
| } | |||
|
|
|||
| public Task deleteIndex(@Nonnull String indexName) throws AlgoliaException { | |||
There was a problem hiding this comment.
Could you add the javadoc for those 2 methods?
There was a problem hiding this comment.
Yes right, totally forgot. Will do.
aseure
force-pushed
the
fix/client-delete-index
branch
from
57054fb
to
5f17a00
Compare
|
@ElPicador I think we're good now. Let me know. |
ElPicador
suggested changes
Feb 13, 2018
| * | ||
| * @param indexName The index name that will be deleted | ||
| * @return The associated task | ||
| * @throws AlgoliaException |
There was a problem hiding this comment.
remove if you do not put a comment
| * @param indexName The index name that will be deleted | ||
| * @param requestOptions Options to pass to this request | ||
| * @return The associated task | ||
| * @throws AlgoliaException |
| @@ -648,7 +648,11 @@ public String generateSecuredApiKey( | |||
| } | |||
|
|
|||
| /** Package protected method for the Index class */ | |||
| CompletableFuture<AsyncTask> deleteIndex(String indexName, RequestOptions requestOptions) { | |||
| CompletableFuture<AsyncTask> deleteIndex(@Nonnull String indexName) { | |||
There was a problem hiding this comment.
the method should be public not protected anymore, like above
aseure
force-pushed
the
fix/client-delete-index
branch
from
5f17a00
to
40449fd
Compare
ElPicador
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
Apparently, the method with
RequestOptionswasn't missing. So here, I'm just adding the one without it, to stay consistent with other methods.Question
However, I have a question: I've also added the
@Nonnullannotations on the existingdeleteIndexmethod. Will it break existing implementations? It will prevent people passingnullfrom compiling but this is really a useful check, it's easy to fix and it shouldn't happen in the first place. WDYT?Test plan
As the first method is already tested for both sync and async clients, I have added no tests.