fix(browser): use auth mode in query string in browser

algolia · Feb 2, 2021 · 0fa6ec5 · 0fa6ec5
1 parent 74972a1
commit 0fa6ec5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/packages/algoliasearch/src/builds/browser.ts b/packages/algoliasearch/src/builds/browser.ts
@@ -17,7 +17,7 @@ import {
   stopABTest,
   StopABTestResponse,
 } from '@algolia/client-analytics';
-import { version, WaitablePromise } from '@algolia/client-common';
+import { AuthMode, version, WaitablePromise } from '@algolia/client-common';
 import {
   createRecommendationClient,
   getPersonalizationStrategy,
@@ -201,6 +201,7 @@ export default function algoliasearch(
       ],
     }),
     userAgent: createUserAgent(version).add({ segment: 'Browser' }),
+    authMode: AuthMode.WithinQueryParameters,
   };
 
   return createSearchClient({

diff --git a/packages/client-common/src/types/AuthModeType.ts b/packages/client-common/src/types/AuthModeType.ts
@@ -1,4 +1,6 @@
-export const AuthMode: Readonly<Record<string, AuthModeType>> = {
+// @MAJOR: export this as individual constants, so it can be minified
+
+export const AuthMode = {
   /**
    * If auth credentials should be in query parameters.
    */
@@ -8,6 +10,6 @@ export const AuthMode: Readonly<Record<string, AuthModeType>> = {
    * If auth credentials should be in headers.
    */
   WithinHeaders: 1,
-};
+} as const;
 
-export type AuthModeType = 0 | 1;
+export type AuthModeType = typeof AuthMode[keyof typeof AuthMode];
diff --git a/packages/transporter/src/types/CallType.ts b/packages/transporter/src/types/CallType.ts
@@ -1,4 +1,6 @@
-export const CallEnum: Readonly<Record<string, CallType>> = {
+// @MAJOR: export this as individual constants, so it can be minified
+
+export const CallEnum = {
   /**
    * If the host is read only.
    */
@@ -13,6 +15,6 @@ export const CallEnum: Readonly<Record<string, CallType>> = {
    * If the host is both read and write.
    */
   Any: 3,
-};
+} as const;
 
-export type CallType = 1 | 2 | 3;
+export type CallType = typeof CallEnum[keyof typeof CallEnum];